Allow CI testing on arm64 hardware #12080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
force-pushed
the
build-on-arm64-hw
branch
from
97daae8
to
73394d3
Compare
Closed
|
Currently our toolchain setting requires cross-compiling on a x64 host, you would need to change |
|
@zcbenz it compiled on arm64 (and successfully ran most of the tests) without changing |
|
@jkleinsc I didn't see you used arm64 build clang, that should be enough. |
jkleinsc
changed the title
jkleinsc
force-pushed
the
build-on-arm64-hw
branch
from
73394d3
to
d31b576
Compare
jkleinsc
changed the title
|
Setting this to WIP until arm64 builds crashing issue ( #12057) is resolved. |
jkleinsc
changed the title
This was referenced Mar 5, 2018
|
I'm going to push my arm64 fixes to this branch. |
zcbenz
force-pushed
the
build-on-arm64-hw
branch
from
d31b576
to
c215391
Compare
zcbenz
changed the title
|
ARM64 CI is only failing for a flaky test: This should be ready to be review/merged. |
jkleinsc
force-pushed
the
build-on-arm64-hw
branch
from
fbd5734
to
bda423f
Compare
jkleinsc
force-pushed
the
build-on-arm64-hw
branch
from
bda423f
to
51f8904
Compare
|
@jkleinsc Should we merge it? The same change has already been merged to |
zcbenz
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of building/testing our arm64 build on arm64 hardware.
There are a couple changes needed to do this:
There isn't a prebuilt ninja binary available for arm64 so the docker image that is used includes a built from source ninja binary. Because the ninja binary isn't in the location it usually is, I added a parameter
ninja-pathto build.py to specify the location of the ninja binary.There isn't a prebuilt clang binary available for arm64, so I created a prebuilt binary for arm64 and updated script/update-clang.sh to pull the prebuilt binary from our s3 bucket.
There is a new CI machine, https://arm64-ci.electronjs.org that I have provisioned for running our CI on actual arm64 hardware (in this case a 96 core arm64 machine that has 2 Cavium ThunderX ARMv8 SoC's).